Add support for Edge on windows #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cderv
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
Looks perfect thank you.
I tested and it is working fine.
More generic question related but not blocking this PR:
- do we want to allow a choice ? We could have something like
find_chrome(which = NULL) # default - use first one found - Chrome then MSEdge
find_chrome(which = "all") # returns all paths found - useful to check
find_chrome(which = "chrome") # returns Chrome
find_chrome(which = "msedge") # returns MSEdgeIt is not useful for pagedown directly and we could keep the idea if there is a need. I though of that mainly because
- I tried
find_chrome("all")because we support it inblogdown::find_hugo("all") - I have chrome AND msedge and I can't really choose which one to use with
find_chrome()- it will always use Google Chrome. I need to set explicitly the env var to test EDGE.
So I would use it :)
@RLesur I could make the change in another PR if you think it would be interesting.
Merge branch 'master' into 160-edge # Conflicts: # NEWS.md
|
Nice suggestion, @cderv! Thanks! I don't think I'll have time in the next days to implement it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the support for Edge on windows in
find_chrome().Close #160