Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NULL handling in promise_all() #50

Merged
merged 2 commits into from
Jul 25, 2019
Merged

Fix NULL handling in promise_all() #50

merged 2 commits into from
Jul 25, 2019

Conversation

wch
Copy link
Collaborator

@wch wch commented Jul 24, 2019

This closes #49.

@wch wch requested a review from jcheng5 July 24, 2019 20:07
@wch wch force-pushed the wch-fix-promise-all-null branch from b80506d to d22f17b Compare July 24, 2019 20:14
@jcheng5
Copy link
Member

jcheng5 commented Jul 24, 2019

Definitely need to get this fix on CRAN, ouch

@wch wch merged commit cc377de into master Jul 25, 2019
@wch wch deleted the wch-fix-promise-all-null branch July 25, 2019 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcheng5 jcheng5 jcheng5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

promise_all() does not handle NULL values correctly
2 participants
@wch @jcheng5