Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #86: future_promise spuriously reporting unhandled errors #90

Merged
merged 8 commits into from
Feb 7, 2023
Merged

Fix #86: future_promise spuriously reporting unhandled errors #90

merged 8 commits into from
Feb 7, 2023

Commits on Feb 7, 2023

  1. Fix #86: future_promise spuriously reporting unhandled errors 

    This was because we were doing a finally() which creates a new
promise, and not subsequently handling errors on that promise.
    @jcheng5
    jcheng5 committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    8c924f4 View commit details
    Browse the repository at this point in the history

  2. Update NEWS.md

    @schloerke
    schloerke committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    b2159ab View commit details
    Browse the repository at this point in the history

  3. Add warning when onFulfilled or onRejected are not functions or `… 

    …NULL`
    @schloerke
    schloerke committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    cebdf25 View commit details
    Browse the repository at this point in the history

  4. Add test for non NULL/function onFulfilled and onRejected values

    @schloerke
    schloerke committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    6c48379 View commit details
    Browse the repository at this point in the history

  5. Bump roxygen version / document

    @schloerke
    schloerke committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    0c2ff82 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into future-promise-unhandled-error

    @schloerke
    schloerke authored Feb 7, 2023
    Configuration menu
    Copy the full SHA
    8d65804 View commit details
    Browse the repository at this point in the history

  7. Remove LazyData from DESCRIPTION

    @schloerke
    schloerke committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    aefe2dc View commit details
    Browse the repository at this point in the history

  8. Attempt to make test more robust on mac by allowing for more time

    @schloerke
    schloerke committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    3939a3c View commit details
    Browse the repository at this point in the history