Add content action. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mine-cetinkaya-rundel
requested changes
Oct 2, 2022
Co-authored-by: Mine Cetinkaya-Rundel <cetinkaya.mine@gmail.com>
…add-content-action
Comment on lines
+161
to
+162
| #' removed from the space. Options for the content are to: "leave" | ||
| #' leaving the content where it is, "archive" moving the content to |
There was a problem hiding this comment.
Seeing "leave" on its own made me realize it might be a bit counter-intuitive -- sounds like leaving a place more than leaving in place. I wonder if the option could be "keep" instead?
- "keep": keep content where it is
- "archive": move tp space archive
- "trash": move to space trash
What do you think?
There was a problem hiding this comment.
I think those would make sense. I might re-map them here. It is a bit more difficult on my end to tweak them at this point.
mine-cetinkaya-rundel
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the remove space user function to support
content_actioninstead ofremove_projects. The workflow here is going to change shortly and when you remove users from a space you will only be able to: leave their content in the space, archive their content (using the relatively new space content archive), or move the space to the trash.Closes #53