Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Copernicus publication template to version 6.2 #366

Merged
merged 2 commits into from
Jan 20, 2021
Merged

Update Copernicus publication template to version 6.2 #366

merged 2 commits into from
Jan 20, 2021

Conversation

RLumSK
Copy link
Contributor

@RLumSK RLumSK commented Jan 20, 2021

This PR updates the Copernicus publication template to the version published 2021-01-15 and add NEWs. I also tested the output and it looks good to me.

To contribute a new article template to this package, please make sure you have done the following things (note that journalname_article below is only an example name):

  • Update NEWS.

Copy link
Collaborator

@cderv cderv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you !

The CI error is the same as what we have in rstudio/rmarkdown#2011 and it is not related. So I'll merge

@cderv cderv merged commit 3365349 into rstudio:master Jan 20, 2021
@cderv
Copy link
Collaborator

cderv commented Jan 20, 2021

One advice for next time @RLumSK : if you remember, please work on a branch before making your PR. It is easier for us to handle PR that are not on master branch. There is no issue really, just better for me to handle PR that are not made on your master. (and easier for you to update your fork after a PR also) . Thank you!

@RLumSK
Copy link
Contributor Author

RLumSK commented Jan 20, 2021

One advice for next time @RLumSK : if you remember, please work on a branch before making your PR. It is easier for us to handle PR that are not on master branch. There is no issue really, just better for me to handle PR that are not made on your master. (and easier for you to update your fork after a PR also) . Thank you!

@cderv Sorry about that. Sure, no problem at all, next time I will do as advised. In particular the latter part "and easier for you to update your fork after a PR also" is indeed an aspect I did not think about before.

@cderv
Copy link
Collaborator

cderv commented Jan 20, 2021

If you are into usethis, the PR helper can help you deal with all that from R
https://usethis.r-lib.org/articles/articles/pr-functions.html

stefanocoretta pushed a commit to stefanocoretta/rticles that referenced this pull request Apr 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants