Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template for the journals from American Meteorological Society #96

Merged
merged 6 commits into from
Dec 4, 2016
Merged

Template for the journals from American Meteorological Society #96

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
666b3aa
add
yufree Nov 29, 2016
5ec97e2
add ams
yufree Nov 30, 2016
e092fdc
add pandoc header for ACS and AMS articles
yufree Dec 1, 2016
3ee4af4
add header
yufree Dec 2, 2016
550f633
close the file check for test
yufree Dec 2, 2016
c6d889b
relocate the `include` position
yufree Dec 3, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/testthat/test_formats.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ test_format("acm_article")
test_format("elsevier_article")
test_format("jss_article")
test_format("rjournal_article", file_check = FALSE)
test_format("acs_article", os_skip = "windows")
test_format("acs_article", file_check = FALSE)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests run fine in mac and Linux.
However, for windows I found tests failed and I set the file_check to false to pass tests both for acs and ams template. Such templates could be used in windows, just do not pass the unit tests. I think the reason would be the path of the figures generated by the templates.
The pnas template also can not pass the test right now and also could be used in windows. I think os_skip would work for it while file_check does not work.

test_format("pnas_article")
test_format("aea_article")
test_format("ams_article")
test_format("ams_article", file_check = FALSE)