Address r-devel's change in is.atomic(NULL) behavior
#3908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
commented
Oct 2, 2023
tests/testthat/test-tabPanel.R
Outdated
Comment on lines
21
to
23
| if (packageVersion("htmltools") <= "0.5.6") { | ||
| skip("Skipping snapshots since htmltools is 'outdated'") | ||
| } |
There was a problem hiding this comment.
This is needed since these tabPanel() tests ultimately call tagQuery() in such a way that rstudio/htmltools#408 becomes problematic (for r-devel).
cpsievert
commented
Oct 2, 2023
gadenbuie
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3906