Warn instead of error when duplicate binding IDs are found in non-devmode #4019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
duplicate-id-warn-not-error
branch
from
46a4328 to
298d8bf
Compare
gadenbuie
reviewed
Mar 29, 2024
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
wch
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4016
Also, while looking through the code, I noticed there was a call to
ShinyClientError()to notify about anidof"". This code actually isn't reachable, since whenidis falsy,bindInputs()/bindOutputs()both exit early before callingaddBinding(). Also, actually throwing aShinyClientError()in that case would likely be problematic for similar reasons, so 298d8bf simply removes it.