Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quote the --data argument for tl_sizes() #330

Merged
merged 2 commits into from
Sep 15, 2021
Merged

quote the --data argument for tl_sizes() #330

merged 2 commits into from
Sep 15, 2021

Conversation

cderv
Copy link
Contributor

@cderv cderv commented Sep 15, 2021

Fix #329

With this PR, tl_sizes() works on WINDOWS

> tl_sizes(pkgs = "luatex")
tlmgr info --list --only-installed --data "name,size" luatex
The total size is 148 Kb
  package   size size_h
1  luatex 151552 148 Kb

@IndrajeetPatil can you test the PR also ?

@yihui I added a test but not sure they run on Windows anyway. 🤷 Forget that, We already switched to GHA so it works

@cderv cderv requested a review from yihui September 15, 2021 15:47
Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@yihui yihui merged commit 10dd936 into master Sep 15, 2021
@yihui yihui deleted the fix/tl-size branch September 15, 2021 16:08
assert('`tl_size()` can correctly list name and size', {
res = tl_sizes(pkgs = "luatex")$package
# only check a few basic packages
('luatex' %==% tl_sizes(pkgs = "luatex")$package)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cderv Out of curiosity, where is the %==% operator from?

GitHub search was not very useful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is from testit framework that we are using for testing in this package
https://github.com/yihui/testit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tl_sizes() does not return sizes for installed LaTeX packages
3 participants