Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video thumbnail issue #2006

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Conversation

Utsav-Ladani
Copy link
Collaborator

Fix video thumbnail issue

  • In the current version, simple video shortcodes in activity are replaced by a custom video player using the MediaElement.js library.
  • This player is not initialized correctly due to ambiguous code, which changes the player using random timeout functions.
  • This PR fix those issue by overwriting BuddyPress's bp.Nouveau.inject function with a custom function.
  • This custom function calls the default function first and then performs the dynamic UI update.

Related issues

@Utsav-Ladani
Copy link
Collaborator Author

Hello @pavanpatil1, Please check and let me know if the customer still has an issue.

@pavanpatil1
Copy link
Collaborator

Hi @Utsav-Ladani, verified this and now the video player is visible fine. But on default theme still the play/pause button is not visible on hover

image

@Utsav-Ladani
Copy link
Collaborator Author

Hello @pavanpatil1, Added fix for the default theme. Please check and let me know.

app/assets/js/rtMedia.backbone.js Outdated Show resolved Hide resolved
@pavanpatil1
Copy link
Collaborator

Verified the fix and it is working fine now on both member and group activity page.

image

@Utsav-Ladani Utsav-Ladani merged commit d5b0167 into pre-release Sep 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants