Detect cycles during development #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (process.env.NODE_ENV !== "production") { | ||
| if (level === undefined) { | ||
| level = 0; | ||
| } |
This was referenced Apr 13, 2016
|
Lovely, thank you! 😻 Two minor suggestions:
Thanks so much for this! |
shamrin
force-pushed
the
detect-cycles
branch
3 times, most recently
from
1acb501
to
660ac2d
Compare
|
Done! I've also written about this problem in wiki. Error message now links to it: https://github.com/rtfeldman/seamless-immutable/wiki/Deeply-nested-object-was-detected |
|
Beautiful! 😻 Thanks so much @shamrin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This throws development-only error when an object is too deeply nested.
Related issues: #73 and #16.