Added static Immutable.sortBy(array[, sorter]) function #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
I'm unsure how to address the build issues in Travis. Can someone assist? |
|
would prefer if no change after sort, return the same reference |
LukeusMaximus
force-pushed
the
static-sort-by
branch
from
c3a78f1 to
7eecb31
Compare
|
What's going on with this Travis build? I'm still unable to proceed. |
|
Build log mentions zuul. Probably related to saucelabs: #249 (comment) |
pekeler
reviewed
Jul 12, 2018
|
|
||
| for (i = 0, length = array.length; i < length; i++) { | ||
| result.push(array[i]); | ||
| } |
There was a problem hiding this comment.
Why not use asMutable() instead of making a mutable copy manually?
pekeler
reviewed
Jul 12, 2018
| // Check if both are NaN. Type checks catch cases where isNaN returns true for strings. | ||
| if(!(typeof result[i] === "number" && isNaN(result[i]) && typeof array[i] === "number" && isNaN(array[i]))) { | ||
| rearranged = true; | ||
| } |
|
@pekeler would this this pull request be ready to merge if the remaining review comments were resolved? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a static sortBy function to the Immutable object. It exposes the basic JS Array#sort functionality. It can take an optional sorting function as per Array#sort.