EVALG-77 follow up: Change design to use Last-Value Cache and Read #703
+299
−276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcamposruiz
requested changes
Sep 24, 2024
alexcamposruiz
requested changes
Oct 3, 2024
alexcamposruiz
requested changes
Oct 3, 2024
| self._metrics_app(), | ||
| self._transit_app(), | ||
| string += f"[INFO] Vehicle {sample.vehicle_vin}" | ||
| if sample.current_route and len(sample.current_route): |
There was a problem hiding this comment.
if sample.current_route:
The and is always true.
There was a problem hiding this comment.
I don't think this is accurate as if sample.current_route will evaluate to sample.current_route.__bool__ which tests for whether if the optional is present or not. Once we've checked that, we need to check that the sequence is not empty.
There was a problem hiding this comment.
Both None and an empty list/string test to False:
>>> bool([])
False
>>> bool(None)
False
>>> bool([1])
True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the example to follow a Last-Value Cache pattern on the subscriber. This removes the need for asynchronous code and focuses on polling.
Additionally, a few other changes have been made as left-over TODO from previous PR, #695.
Details and comments
Checks