add type info for dashboard and visualization

Signed-off-by: yuye-aws <yuyezhu@amazon.com>
ruanyl · Sep 18, 2023 · 6667a64 · 6667a64
1 parent fc42473
commit 6667a64
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/src/plugins/dashboard/public/application/utils/get_nav_actions.tsx b/src/plugins/dashboard/public/application/utils/get_nav_actions.tsx
@@ -152,10 +152,9 @@ export const getNavActions = (
       includeReferencesDeep: boolean,
       targetWorkspace: string
     ) => {
-      // object must be dashboard type
       const objectsToDuplicate = dashboardSavedObjects.map((obj) => ({
         id: obj.id,
-        type: 'dashboard',
+        type: obj.type,
       }));
 
       try {
@@ -181,7 +180,10 @@ export const getNavActions = (
     };
 
     const currentWorkspace = workspaces.currentWorkspace$.value;
-    const dashboardSavedObject = (savedDashboard as unknown) as SavedObjectWithMetadata;
+    const dashboardSavedObject = ({
+      ...currentContainer,
+      ...savedDashboard,
+    } as unknown) as SavedObjectWithMetadata;
     dashboardSavedObject.meta = { title: savedDashboard.title };
 
     const showDuplicateModalProps = {

diff --git a/src/plugins/visualize/public/application/utils/get_top_nav_config.tsx b/src/plugins/visualize/public/application/utils/get_top_nav_config.tsx
@@ -283,10 +283,9 @@ export const getTopNavConfig = (
                 includeReferencesDeep: boolean,
                 targetWorkspace: string
               ) => {
-                // object must be visualization type
                 const objectsToDuplicate = visualizationSavedObjects.map((obj) => ({
                   id: obj.id,
-                  type: 'visualization',
+                  type: obj.type,
                 }));
 
                 try {
@@ -311,7 +310,10 @@ export const getTopNavConfig = (
               };
 
               const currentWorkspace = workspaces.currentWorkspace$.value;
-              const visualizationSavedObject = (savedVis as unknown) as SavedObjectWithMetadata;
+              const visualizationSavedObject = ({
+                ...embeddableHandler,
+                ...savedVis,
+              } as unknown) as SavedObjectWithMetadata;
               visualizationSavedObject.meta = { title: savedVis.title }; // meta is missing in savedVis
 
               const showDuplicateModalProps = {