-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refractor: remove processFindOptions
and getPermissionQuery
methods declaration in repositoryClient
#142
Conversation
processFindOptions
and getPermissionQuery
methods declaration in repositoryClient
processFindOptions
and getPermissionQuery
methods declaration in repositoryClientprocessFindOptions
and getPermissionQuery
methods declaration in repositoryClient
Codecov Report
@@ Coverage Diff @@
## workspace #142 +/- ##
=============================================
+ Coverage 65.75% 65.82% +0.06%
=============================================
Files 3336 3336
Lines 64555 64538 -17
Branches 10292 10288 -4
=============================================
+ Hits 42450 42482 +32
+ Misses 19523 19509 -14
+ Partials 2582 2547 -35
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
e4f3f79
to
c281c3e
Compare
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
src/core/server/saved_objects/service/lib/search_dsl/query_params.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9 workspace-2.9
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9
# Create a new branch
git switch --create backport/backport-142-to-workspace-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 05fab00a1e9f90ccfae754bd4073c3fa4954b774
# Push it to GitHub
git push --set-upstream origin backport/backport-142-to-workspace-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9 Then, create a pull request where the |
…ds declaration in repositoryClient (#142) (#157) * refractor: remove additional method declaration Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: make bootstrap run Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change to single permission modes Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: rename variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> (cherry picked from commit 05fab00)
…ds declaration in repositoryClient (#142) * refractor: remove additional method declaration Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: make bootstrap run Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change to single permission modes Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: rename variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
…ds declaration in repositoryClient (#142) * refractor: remove additional method declaration Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: make bootstrap run Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: change to single permission modes Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: rename variable Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jest
yarn test:jest_integration
yarn test:ftr