Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refractor: remove processFindOptions and getPermissionQuery methods declaration in repositoryClient #142

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

SuZhou-Joe
Copy link
Collaborator

@SuZhou-Joe SuZhou-Joe commented Sep 11, 2023

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@SuZhou-Joe SuZhou-Joe changed the title refractor: remove additional method declaration refractor: remove processFindOptions and getPermissionQuery methods declaration in repositoryClient Sep 11, 2023
@SuZhou-Joe SuZhou-Joe changed the title refractor: remove processFindOptions and getPermissionQuery methods declaration in repositoryClient Refractor: remove processFindOptions and getPermissionQuery methods declaration in repositoryClient Sep 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2023

Codecov Report

Merging #142 (e4f3f79) into workspace (0bd03df) will increase coverage by 0.06%.
Report is 3 commits behind head on workspace.
The diff coverage is 5.00%.

@@              Coverage Diff              @@
##           workspace     #142      +/-   ##
=============================================
+ Coverage      65.75%   65.82%   +0.06%     
=============================================
  Files           3336     3336              
  Lines          64555    64538      -17     
  Branches       10292    10288       -4     
=============================================
+ Hits           42450    42482      +32     
+ Misses         19523    19509      -14     
+ Partials        2582     2547      -35     
Flag Coverage Δ
Linux_1 34.74% <0.00%> (?)
Linux_2 54.78% <5.00%> (?)
Linux_3 42.60% <0.00%> (?)
Linux_4 34.75% <0.00%> (?)
Windows_1 34.76% <0.00%> (ø)
Windows_2 54.75% <5.00%> (+0.03%) ⬆️
Windows_3 42.61% <0.00%> (+0.02%) ⬆️
Windows_4 34.75% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../server/saved_objects/permission_control/client.ts 2.77% <0.00%> (-0.26%) ⬇️
...erver/saved_objects/service/lib/repository.mock.ts 100.00% <ø> (ø)
...ore/server/saved_objects/service/lib/repository.ts 82.71% <ø> (+2.82%) ⬆️
...ved_objects/service/lib/search_dsl/query_params.ts 75.00% <0.00%> (-7.11%) ⬇️
...saved_objects/service/lib/search_dsl/search_dsl.ts 100.00% <ø> (ø)
src/core/server/saved_objects/service/lib/utils.ts 100.00% <ø> (+26.08%) ⬆️
...rver/saved_objects/service/saved_objects_client.ts 57.69% <ø> (+1.02%) ⬆️
.../core/public/saved_objects/saved_objects_client.ts 82.56% <50.00%> (ø)

... and 15 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Copy link
Collaborator

@wanglam wanglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuZhou-Joe SuZhou-Joe merged commit 05fab00 into ruanyl:workspace Sep 13, 2023
@opensearch-workspace-development

The backport to workspace-2.9 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9 workspace-2.9
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9
# Create a new branch
git switch --create backport/backport-142-to-workspace-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 05fab00a1e9f90ccfae754bd4073c3fa4954b774
# Push it to GitHub
git push --set-upstream origin backport/backport-142-to-workspace-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9

Then, create a pull request where the base branch is workspace-2.9 and the compare/head branch is backport/backport-142-to-workspace-2.9.

SuZhou-Joe added a commit that referenced this pull request Sep 14, 2023
…ds declaration in repositoryClient (#142) (#157)

* refractor: remove additional method declaration

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: make bootstrap run

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: change to single permission modes

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: rename variable

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit 05fab00)
ruanyl pushed a commit that referenced this pull request Sep 15, 2023
…ds declaration in repositoryClient (#142)

* refractor: remove additional method declaration

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: make bootstrap run

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: change to single permission modes

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: rename variable

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
SuZhou-Joe added a commit that referenced this pull request Sep 16, 2023
…ds declaration in repositoryClient (#142)

* refractor: remove additional method declaration

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: make bootstrap run

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: change to single permission modes

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: rename variable

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants