Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add core workspace module #145

Merged
merged 6 commits into from
Sep 19, 2023
Merged

feat: add core workspace module #145

merged 6 commits into from
Sep 19, 2023

Conversation

ruanyl
Copy link
Owner

@ruanyl ruanyl commented Sep 12, 2023 •
edited by SuZhou-Joe
Loading

Description

The core workspace module(WorkspaceService) is a foundational component that enables the implementation of workspace features within OSD plugins. The purpose of the core workspace module is to provide a framework for workspace implementations.

This module does not implement specific workspace functionality but provides the essential infrastructure for plugins to extend and customize workspace features, it maintains a shared workspace state(observables) across the entire application to ensure a consistent and up-to-date view of workspace-related information to all parts of the application.

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2023 •
edited
Loading

Codecov Report

Merging #145 (edb0a67) into workspace-pr-integr (f1eb762) will decrease coverage by 0.01%.
The diff coverage is 55.26%.

@@                   Coverage Diff                   @@
##           workspace-pr-integr     #145      +/-   ##
=======================================================
- Coverage                66.50%   66.49%   -0.01%     
=======================================================
  Files                     3406     3408       +2     
  Lines                    65111    65149      +38     
  Branches                 10426    10431       +5     
=======================================================
+ Hits                     43302    43323      +21     
- Misses                   19221    19237      +16     
- Partials                  2588     2589       +1
Flag Coverage Δ
Linux_1 34.81% <21.05%> (-0.02%) ⬇️
Linux_2 55.35% <55.26%> (-0.01%) ⬇️
Linux_3 44.58% <21.05%> (-0.03%) ⬇️
Linux_4 34.88% <21.05%> (-0.02%) ⬇️
Windows_1 34.82% <21.05%> (-0.02%) ⬇️
Windows_2 55.31% <55.26%> (-0.01%) ⬇️
Windows_3 44.58% <21.05%> (-0.03%) ⬇️
Windows_4 34.88% <21.05%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/core/public/mocks.ts 59.09% <ø> (ø)
src/core/public/plugins/plugin_context.ts 44.44% <ø> (ø)
src/core/public/workspace/workspaces_service.ts 37.03% <37.03%> (ø)
src/core/public/core_system.ts 91.86% <100.00%> (+0.29%) ⬆️
...c/core/public/workspace/workspaces_service.mock.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ruanyl ruanyl force-pushed the workspace-pr-integr-2.9 branch from f02a059 to f1eb762 Compare September 15, 2023 09:18
@ruanyl
feat: add core workspace module
133dff4 
The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@ruanyl
refactor: align naming convention
49ab913 
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@ruanyl ruanyl force-pushed the feature/core-workspace-service branch from 5899c9b to 49ab913 Compare September 15, 2023 09:23
@ruanyl
fix failed snapshot
6100ab9 
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@ruanyl
feat: add readonly flag to workspace object
661122f 
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@ruanyl
feat: add attribute reserved to workspace object type
55cb831 
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@ruanyl
fix failed test snapshots
edb0a67 
Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
@ruanyl ruanyl merged commit d7d712e into workspace-pr-integr Sep 19, 2023
94 of 95 checks passed
ruanyl added a commit that referenced this pull request Sep 22, 2023
@ruanyl
feat: add core workspace module (#145)
ab24720 
The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl added a commit that referenced this pull request Sep 28, 2023
@ruanyl
feat: add core workspace module (#145)
8382b59 
The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl added a commit that referenced this pull request Oct 13, 2023
@ruanyl
feat: add core workspace module (#145)
e35290a 
The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl added a commit that referenced this pull request Oct 18, 2023
@ruanyl @AMoo-Miki
[Workspace] Feature/workspace service core module (opensearch-project…
9e3e3a7 
…#5092)

* feat: add core workspace module (#145)

The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyu1@gmail.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
wanglam pushed a commit that referenced this pull request Feb 26, 2024
@ruanyl @wanglam
feat: add core workspace module (#145)
481f90b 
The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Mar 11, 2024
@ruanyl @SuZhou-Joe
feat: add core workspace module (#145)
be9b890 
The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe pushed a commit that referenced this pull request Mar 18, 2024
@ruanyl @SuZhou-Joe
feat: add core workspace module (#145)
bc555d2 
The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

---------

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
ruanyl pushed a commit that referenced this pull request Apr 16, 2024
@opensearch-trigger-bot @github-actions
@ananzh @AMoo-Miki
[Backport 2.x] [Workspace] Feature/workspace service core module (ope…
60247dd 
…nsearch-project#5416)

* [Workspace] Feature/workspace service core module (opensearch-project#5092)

* feat: add core workspace module (#145)

The core workspace module(WorkspaceService) is a foundational component
that enables the implementation of workspace features within OSD
plugins. The purpose of the core workspace module is to provide
a framework for workspace implementations.

This module does not implement specific workspace
functionality but provides the essential infrastructure for plugins to
extend and customize workspace features, it maintains a shared
workspace state(observables) across the entire application to ensure
a consistent and up-to-date view of workspace-related information to
all parts of the application.

Signed-off-by: Yulong Ruan <ruanyl@amazon.com>
Signed-off-by: Yulong Ruan <ruanyu1@gmail.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit 9e3e3a7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Signed-off-by: Anan Zhuang <ananzh@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Anan Zhuang <ananzh@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hailong-am Hailong-am Hailong-am approved these changes

@raintygao raintygao raintygao approved these changes

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@wanglam wanglam wanglam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ruanyl @codecov-commenter @wanglam @SuZhou-Joe @raintygao @Hailong-am