Remove public workspace logic for share API

[Hailong-am]

Description

Issues Resolved

Screenshot

Testing the changes

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[wanglam]

@Hailong-am Is that means for saved objects with PUBLIC workspace can be shared to other workspaces?

[codecov-commenter]

Codecov Report

Merging #149 (ad7eca2) into workspace (05fab00) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##           workspace     #149      +/-   ##
=============================================
+ Coverage      65.71%   65.73%   +0.01%     
=============================================
  Files           3336     3336              
  Lines          64657    64656       -1     
  Branches       10318    10316       -2     
=============================================
+ Hits           42488    42500      +12     
+ Misses         19590    19577      -13     
  Partials        2579     2579              

Flag	Coverage Δ
Linux_1	34.74% <ø> (ø)
Linux_3	42.54% <0.00%> (+<0.01%)	⬆️
Linux_4	34.70% <0.00%> (+<0.01%)	⬆️
Windows_1	34.80% <ø> (+0.04%)	⬆️
Windows_2	54.67% <0.00%> (+<0.01%)	⬆️
Windows_3	42.55% <0.00%> (+<0.01%)	⬆️
Windows_4	34.70% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
src/core/server/saved_objects/routes/index.ts	100.00% <ø> (ø)
src/core/server/saved_objects/routes/share.ts	12.50% <0.00%> (ø)
...ore/server/saved_objects/service/lib/repository.ts	78.53% <0.00%> (+0.13%)	⬆️
...rver/saved_objects/service/saved_objects_client.ts	55.17% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[Hailong-am]

@Hailong-am Is that means for saved objects with PUBLIC workspace can be shared to other workspaces?

As we don't have any special logic for public workspace, based on that i removed the limitation for public workspace.

[opensearch-workspace-development]

The backport to workspace-2.9 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9 workspace-2.9
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9
# Create a new branch
git switch --create backport/backport-149-to-workspace-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 aa51f8420cc1c746f4ac9c9c4e3a08130410f40b
# Push it to GitHub
git push --set-upstream origin backport/backport-149-to-workspace-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9

Then, create a pull request where the base branch is workspace-2.9 and the compare/head branch is backport/backport-149-to-workspace-2.9.

[opensearch-workspace-development]

The backport to workspace-2.9 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9 workspace-2.9
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9
# Create a new branch
git switch --create backport/backport-149-to-workspace-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 aa51f8420cc1c746f4ac9c9c4e3a08130410f40b
# Push it to GitHub
git push --set-upstream origin backport/backport-149-to-workspace-2.9
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-workspace-2.9

Then, create a pull request where the base branch is workspace-2.9 and the compare/head branch is backport/backport-149-to-workspace-2.9.