Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport workspace-2.9]Refractor: move permission control service to workspace directory and keep saved objects as clean as possible (#166) #172

Conversation

SuZhou-Joe
Copy link
Collaborator

@SuZhou-Joe SuZhou-Joe commented Sep 15, 2023

  • refractor: move permission control service to workspace directory and keep saved objects as clean as possible

Signed-off-by: SuZhou-Joe suzhou@amazon.com

  • feat: make lint pass

Signed-off-by: SuZhou-Joe suzhou@amazon.com


Signed-off-by: SuZhou-Joe suzhou@amazon.com
(cherry picked from commit c2a9bd2)

Description

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

… keep saved objects as clean as possible (opensearch-project#166)

* refractor: move permission control service to workspace directory and keep saved objects as clean as possible

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

* feat: make lint pass

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>

---------

Signed-off-by: SuZhou-Joe <suzhou@amazon.com>
(cherry picked from commit c2a9bd2)
@SuZhou-Joe SuZhou-Joe changed the title Refractor: move permission control service to workspace directory and keep saved objects as clean as possible (#166) [Backport workspace-2.9]Refractor: move permission control service to workspace directory and keep saved objects as clean as possible (#166) Sep 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2023

Codecov Report

Merging #172 (094499f) into workspace-2.9 (b33221a) will increase coverage by 0.04%.
Report is 2 commits behind head on workspace-2.9.
The diff coverage is 0.00%.

@@                Coverage Diff                @@
##           workspace-2.9     #172      +/-   ##
=================================================
+ Coverage          54.72%   54.77%   +0.04%     
=================================================
  Files               3038     3033       -5     
  Lines              60497    60442      -55     
  Branches            9528     9520       -8     
=================================================
- Hits               33108    33105       -3     
+ Misses             25446    25394      -52     
  Partials            1943     1943              
Flag Coverage Δ
Linux_1 34.76% <0.00%> (+<0.01%) ⬆️
Linux_3 42.80% <0.00%> (+0.06%) ⬆️
Linux_4 34.74% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...c/core/public/chrome/ui/header/collapsible_nav.tsx 0.00% <0.00%> (ø)
src/core/server/index.ts 100.00% <ø> (ø)
src/core/server/legacy/legacy_service.ts 0.00% <ø> (ø)
src/core/server/plugins/plugin_context.ts 0.00% <ø> (ø)
...server/saved_objects/saved_objects_service.mock.ts 70.83% <ø> (ø)
...core/server/saved_objects/saved_objects_service.ts 0.00% <ø> (ø)
src/core/utils/default_app_categories.ts 100.00% <ø> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SuZhou-Joe SuZhou-Joe merged commit d980ee4 into ruanyl:workspace-2.9 Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants