Fix typo #176
Merged
Fix typo #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## workspace #176 +/- ##
==============================================
+ Coverage 34.82% 61.39% +26.56%
==============================================
Files 1942 2982 +1040
Lines 38428 57792 +19364
Branches 5499 9360 +3861
==============================================
+ Hits 13384 35481 +22097
+ Misses 24438 20224 -4214
- Partials 606 2087 +1481
Flags with carried forward coverage won't be shown. Click here to find out more. see 1639 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
opensearch-workspace-development bot
pushed a commit
that referenced
this pull request
Sep 18, 2023
--------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> (cherry picked from commit e296a5d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 18, 2023
yuye-aws
added a commit
that referenced
this pull request
Sep 20, 2023
* rename copy to duplicate Signed-off-by: yuye-aws <yuyezhu@amazon.com> * duplicate in visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * duplicate in dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve conflict Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update test and snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> * re-duplicate if some objects cannot be duplicated Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove clone for dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * rename duplicateState to duplicateMode Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change workspace prop to currentWorkspace in SavedObjectsDuplicateModal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change wording Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move duplicate modal to saved_objects for reuse Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move duplicate modal to saved objects management for reuse Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove minimal duplicate modal props logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor duplicate modal props for dashboard and visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Update getDuplicateWorkspaces function Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> * update function onDuplicate for dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Update doDuplicate for visualization Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> * refactor function getDuplicateWorkspaces Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add i18n context to saved objects table duplicate modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor duplicate modal logic in saved object table Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add error message for partial duplicate failed Signed-off-by: yuye-aws <yuyezhu@amazon.com> * merge commits Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add type info for dashboard and visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remote create vis reference logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Revert "remove clone for dashboard" This reverts commit 84f77fb. * hide duplicate when workspace disabled in dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * feat: skip permission validate when no workspaces and permissions attributes (#163) * feat: skip permission validate when saved object without workspaces and permissions attributes Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add annontation to skip permission check Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: remove bind and simplify validate logic Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: remove library write for object based ACL Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> * remove get workspaces with write permission logic and add readonly props to workspace attribute Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change type definition logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Fix typo (#176) --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * remove exit workspace logic (#179) Signed-off-by: yuye-aws <yuyezhu@amazon.com> * rename copy to duplicate Signed-off-by: yuye-aws <yuyezhu@amazon.com> * duplicate in visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * duplicate in dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve conflict Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update test and snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> * re-duplicate if some objects cannot be duplicated Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove clone for dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * rename duplicateState to duplicateMode Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change workspace prop to currentWorkspace in SavedObjectsDuplicateModal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change wording Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move duplicate modal to saved_objects for reuse Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move duplicate modal to saved objects management for reuse Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove minimal duplicate modal props logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor duplicate modal props for dashboard and visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Update getDuplicateWorkspaces function Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> * update function onDuplicate for dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Update doDuplicate for visualization Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> * refactor function getDuplicateWorkspaces Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add i18n context to saved objects table duplicate modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor duplicate modal logic in saved object table Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add error message for partial duplicate failed Signed-off-by: yuye-aws <yuyezhu@amazon.com> * merge commits Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add type info for dashboard and visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remote create vis reference logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Revert "remove clone for dashboard" This reverts commit 84f77fb. * hide duplicate when workspace disabled in dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove get workspaces with write permission logic and add readonly props to workspace attribute Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change type definition logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * rename variable and function name Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change permission mode to get target workspaces when duplicate Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> Co-authored-by: Lin Wang <wonglam@amazon.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Add copy saved objects among workspaces functionality (#53) * Add copy saved objects among workspaces functionality Signed-off-by: gaobinlong <gbinlong@amazon.com> Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix bug Signed-off-by: gaobinlong <gbinlong@amazon.com> * Fix bug Signed-off-by: gaobinlong <gbinlong@amazon.com> --------- Signed-off-by: gaobinlong <gbinlong@amazon.com> # Conflicts: # src/core/server/saved_objects/routes/copy.ts # src/plugins/saved_objects_management/public/constants.ts # src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx * feat: duplicate selected objects (#113) * fix typo Signed-off-by: yuye-aws <yuyezhu@amazon.com> * adjust copy modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * list workspace with write permission on copy modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add copy icon and move getcopyworkspaces function from copy_modal to saved_object table Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix duplicate error in public workspace and change copy to duplicate all in header Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bug fix: create saved objects in public workspace Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove unused import Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change validate schema Signed-off-by: yuye-aws <yuyezhu@amazon.com> * behavior subject bug fix for workspace plugin Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> # Conflicts: # src/core/public/chrome/ui/header/__snapshots__/header.test.tsx.snap # src/core/server/saved_objects/permission_control/acl.test.ts # src/core/server/saved_objects/permission_control/client.ts # src/plugins/saved_objects_management/public/management_section/objects_table/components/copy_modal.tsx # src/plugins/workspace/server/plugin.ts # src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts * Saved objects page change (#123) * hide import for application home page Signed-off-by: Hailong Cui <ihailong@amazon.com> * add workpspace into gotoApp link Signed-off-by: Hailong Cui <ihailong@amazon.com> * remove special logic for management workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * variable name change and more UTs Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> # Conflicts: # src/plugins/saved_objects_management/public/management_section/objects_table/__snapshots__/saved_objects_table.test.tsx.snap # src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/header.test.tsx.snap # src/plugins/saved_objects_management/public/management_section/objects_table/components/table.test.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/components/table.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.test.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx * feat: duplicate all and single objects (#121) * implement all duplicate copy modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add spacer after checkbox list Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add fail message for copy saved objects Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change title wording to manage library Signed-off-by: yuye-aws <yuyezhu@amazon.com> * single duplicate Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change wording Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove comment Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bug fix: keep selected saved objects info when cancel duplicate all Signed-off-by: yuye-aws <yuyezhu@amazon.com> * fix typo Signed-off-by: yuye-aws <yuyezhu@amazon.com> * use icu syntax in copy message Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bug fix: keep selected saved objects info when cancel duplicate single Signed-off-by: yuye-aws <yuyezhu@amazon.com> * set current workspace as the first option Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshot Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve conflict Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshot Signed-off-by: yuye-aws <yuyezhu@amazon.com> * bug fix for saved object table Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshot Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove unused file Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change i18n constant Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove empty push Signed-off-by: yuye-aws <yuyezhu@amazon.com> * hide duplicate when workspace is disabled Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> # Conflicts: # src/plugins/saved_objects_management/public/constants.ts # src/plugins/saved_objects_management/public/management_section/objects_table/__snapshots__/saved_objects_table.test.tsx.snap # src/plugins/saved_objects_management/public/management_section/objects_table/components/copy_modal.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/components/header.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx # src/plugins/saved_objects_management/public/plugin.ts * feat: Duplicate dashboard visualize (#148) * rename copy to duplicate Signed-off-by: yuye-aws <yuyezhu@amazon.com> * duplicate in visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * duplicate in dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve conflict Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update test and snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> * re-duplicate if some objects cannot be duplicated Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove clone for dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * rename duplicateState to duplicateMode Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change workspace prop to currentWorkspace in SavedObjectsDuplicateModal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change wording Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move duplicate modal to saved_objects for reuse Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move duplicate modal to saved objects management for reuse Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove minimal duplicate modal props logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor duplicate modal props for dashboard and visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Update getDuplicateWorkspaces function Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> * update function onDuplicate for dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Update doDuplicate for visualization Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> * refactor function getDuplicateWorkspaces Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add i18n context to saved objects table duplicate modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor duplicate modal logic in saved object table Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add error message for partial duplicate failed Signed-off-by: yuye-aws <yuyezhu@amazon.com> * merge commits Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add type info for dashboard and visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remote create vis reference logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Revert "remove clone for dashboard" This reverts commit 84f77fb. * hide duplicate when workspace disabled in dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * feat: skip permission validate when no workspaces and permissions attributes (#163) * feat: skip permission validate when saved object without workspaces and permissions attributes Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: add annontation to skip permission check Signed-off-by: Lin Wang <wonglam@amazon.com> * refactor: remove bind and simplify validate logic Signed-off-by: Lin Wang <wonglam@amazon.com> * feat: remove library write for object based ACL Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> * remove get workspaces with write permission logic and add readonly props to workspace attribute Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change type definition logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Fix typo (#176) --------- Signed-off-by: Yulong Ruan <ruanyl@amazon.com> * remove exit workspace logic (#179) Signed-off-by: yuye-aws <yuyezhu@amazon.com> * rename copy to duplicate Signed-off-by: yuye-aws <yuyezhu@amazon.com> * duplicate in visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * duplicate in dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * resolve conflict Signed-off-by: yuye-aws <yuyezhu@amazon.com> * update test and snapshots Signed-off-by: yuye-aws <yuyezhu@amazon.com> * re-duplicate if some objects cannot be duplicated Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove clone for dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * rename duplicateState to duplicateMode Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change workspace prop to currentWorkspace in SavedObjectsDuplicateModal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change wording Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move duplicate modal to saved_objects for reuse Signed-off-by: yuye-aws <yuyezhu@amazon.com> * move duplicate modal to saved objects management for reuse Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove minimal duplicate modal props logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor duplicate modal props for dashboard and visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Update getDuplicateWorkspaces function Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> * update function onDuplicate for dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Update doDuplicate for visualization Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> * refactor function getDuplicateWorkspaces Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add i18n context to saved objects table duplicate modal Signed-off-by: yuye-aws <yuyezhu@amazon.com> * refactor duplicate modal logic in saved object table Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add error message for partial duplicate failed Signed-off-by: yuye-aws <yuyezhu@amazon.com> * merge commits Signed-off-by: yuye-aws <yuyezhu@amazon.com> * add type info for dashboard and visualization Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remote create vis reference logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * Revert "remove clone for dashboard" This reverts commit 84f77fb. * hide duplicate when workspace disabled in dashboard Signed-off-by: yuye-aws <yuyezhu@amazon.com> * remove get workspaces with write permission logic and add readonly props to workspace attribute Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change type definition logic Signed-off-by: yuye-aws <yuyezhu@amazon.com> * rename variable and function name Signed-off-by: yuye-aws <yuyezhu@amazon.com> * change permission mode to get target workspaces when duplicate Signed-off-by: yuye-aws <yuyezhu@amazon.com> --------- Signed-off-by: yuye-aws <yuyezhu@amazon.com> Signed-off-by: Lin Wang <wonglam@amazon.com> Signed-off-by: Yulong Ruan <ruanyl@amazon.com> Co-authored-by: Yulong Ruan <ruanyu1@gmail.com> Co-authored-by: Lin Wang <wonglam@amazon.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com> # Conflicts: # src/core/public/workspace/workspaces_service.ts # src/plugins/saved_objects_management/public/constants.ts # src/plugins/saved_objects_management/public/management_section/objects_table/components/duplicate_modal.tsx # src/plugins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx # src/plugins/workspace/server/saved_objects/workspace_saved_objects_client_wrapper.ts * delete useless code * refactor dupicate_model code and fix test error * add duplicate all/selected saved objects unit test * add util and copy unit test Signed-off-by: yubonluo <yubonluo@amazon.com> * fix bug Signed-off-by: yubonluo <yubonluo@amazon.com> * fix unit test error Signed-off-by: yubonluo <yubonluo@amazon.com> * add all unit test and fix code error Signed-off-by: yubonluo <yubonluo@amazon.com> * revert useless modifications Signed-off-by: yubonluo <yubonluo@amazon.com> * add snapshot code Signed-off-by: yubonluo <yubonluo@amazon.com> * delete useless code Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize code Signed-off-by: yubonluo <yubonluo@amazon.com> * split duplicate_modal Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize code Signed-off-by: yubonluo <yubonluo@amazon.com> * fix unit test Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize code Signed-off-by: yubonluo <yubonluo@amazon.com> * Fixed the bug that can not duplicate all saved objects Signed-off-by: yubonluo <yubonluo@amazon.com> * Fixed the bug that can not duplicate all saved objects Signed-off-by: yubonluo <yubonluo@amazon.com> * optimize code Signed-off-by: yubonluo <yubonluo@amazon.com> * delete useless code Signed-off-by: yubonluo <yubonluo@amazon.com> --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: gaobinlong <gbl_long@163.com> Co-authored-by: Yuye Zhu <yuyezhu@amazon.com> Co-authored-by: Hailong Cui <ihailong@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
Screenshot
Testing the changes
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr