Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix media type by assigning it with creative type, create video cache… #12

Closed
wants to merge 3 commits into from
Closed

fix media type by assigning it with creative type, create video cache… #12

wants to merge 3 commits into from

Conversation

moonshells
Copy link

@moonshells moonshells commented Jan 23, 2018 •
edited
Loading

… key with the value of impression id

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@moonshells moonshells self-assigned this Jan 23, 2018
snapwich
snapwich approved these changes Jan 24, 2018
View reviewed changes
Copy link

@snapwich snapwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but that typo should probably be fixed in the comment.

modules/rubiconBidAdapter.js Outdated
cpm: ad.cpm || 0,
dealId: ad.deal,
ttl: 300, // 5 minutes
ttl: 300, // 5 minutess
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably don't need this

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. I have fixed this typo.

@moonshells moonshells closed this Jan 25, 2018
@moonshells moonshells deleted the add_video_cache_key branch January 25, 2018 20:33
robertrmartinez pushed a commit that referenced this pull request Feb 28, 2020
@abijr @juanbono @raz-adroll
NextRoll Bidder Adapter (prebid#4829)
0ae0bff 
* First implementation of the AdRoll adapter (#1)

* Fix request and bid id (#5)

* Send Zone ID (#6)

* Add age check before fastbid eval (#7)

* Add age check before fastbid eval

* Fix linting

* Add date check (#8)

* Add date exists check

* Remove logging statement

* Fix bidRequest validation (#9)

* Fix deprecated function usage (#10)

* [SENG-2757] remove custom function from adapter (#11)

* remove loadExternalScript function

* add adroll to the adloader whitelist

* Handle nextroll id (#12)

* Handle nextroll id

* Remove double nesting in user obj

* Revert change to publisherTagAvailable

* Rename adroll -> nextroll (#14)

* Rename fastbid -> pubtag functions and variables (#15)

* Improve coverage of tests

* Add docs

* Add docs

* Improve sizes and add sellerid

* Add maintainer email

* Fix CI problem

* Fix IE tests

* Replace second instance of find

* Fix types used in the doc

Match prebid/prebid.github.io#1796

* Remove unused fields in spec

* Add ccpa support

* Remove external script usage

* Remove IP field

* Remove pubtag key

* Rename imports; Remove getUserSync function; Remove unused code; Use url.parse function

Co-authored-by: Juan Bono <juanbono94@gmail.com>
Co-authored-by: Ricardo Azpeitia Pimentel <ricardo.azpeitia@nextroll.com>
robertrmartinez pushed a commit that referenced this pull request May 22, 2023
@BrettBlox @antoinfive
Concert Bid Adapter: enable support for GPP consent and remove user s…
33d015d 
…ync (prebid#9700)

* collect EIDs for bid request

* add ad slot positioning to payload

* RPO-2012: Update local storage name-spacing for c_uid (#8)

* Updates c_uid namespacing to be more specific for concert

* fixes unit tests

* remove console.log

* RPO-2012: Add check for shared id (#9)

* Adds check for sharedId

* Updates cookie name

* remove trailing comma

* [RPO-3152] Enable Support for GPP Consent (#12)

* Adds gpp consent integration to concert bid adapter

* Update tests to check for gpp consent string param

* removes user sync endpoint and tests

* updates comment

* cleans up consentAllowsPpid function

* comment fix

* rename variables for clarity

* fixes conditional logic for consent allows function (#13)

---------

Co-authored-by: antoin <antoin.campbell@voxmedia.com>
Co-authored-by: Antoin <antoinfive@gmail.com>
robertrmartinez pushed a commit that referenced this pull request May 22, 2023
@BrettBlox @antoinfive
Concert Bid Adapter: Enable support for additional userId's (prebid#9780
86e6ef5 
)

* collect EIDs for bid request

* add ad slot positioning to payload

* RPO-2012: Update local storage name-spacing for c_uid (#8)

* Updates c_uid namespacing to be more specific for concert

* fixes unit tests

* remove console.log

* RPO-2012: Add check for shared id (#9)

* Adds check for sharedId

* Updates cookie name

* remove trailing comma

* [RPO-3152] Enable Support for GPP Consent (#12)

* Adds gpp consent integration to concert bid adapter

* Update tests to check for gpp consent string param

* removes user sync endpoint and tests

* updates comment

* cleans up consentAllowsPpid function

* comment fix

* rename variables for clarity

* fixes conditional logic for consent allows function (#13)

* [RPO-3262] Update getUid function to check for pubcid and sharedid (#14)

* Update getUid function to check for pubcid and sharedid

* updates adapter version

---------

Co-authored-by: antoin <antoin.campbell@voxmedia.com>
Co-authored-by: Antoin <antoinfive@gmail.com>
robertrmartinez pushed a commit that referenced this pull request Jul 5, 2023
@sebrobert
Remove entirely the notion of 'auction_id' as we do not do anything w…
72d8754 
…ith it (#12) (prebid#10129)
musikele pushed a commit that referenced this pull request Aug 28, 2023
@sebrobert
Remove entirely the notion of 'auction_id' as we do not do anything w…
afb911b 
…ith it (#12) (prebid#10129)
musikele pushed a commit that referenced this pull request Aug 28, 2023
@Skitelman @antoinfive @BrettBlox
ConcertBidAdapter: Add browserLanguage to request meta object (pr…
d63c627 
…ebid#10356)

* collect EIDs for bid request

* add ad slot positioning to payload

* RPO-2012: Update local storage name-spacing for c_uid (#8)

* Updates c_uid namespacing to be more specific for concert

* fixes unit tests

* remove console.log

* RPO-2012: Add check for shared id (#9)

* Adds check for sharedId

* Updates cookie name

* remove trailing comma

* [RPO-3152] Enable Support for GPP Consent (#12)

* Adds gpp consent integration to concert bid adapter

* Update tests to check for gpp consent string param

* removes user sync endpoint and tests

* updates comment

* cleans up consentAllowsPpid function

* comment fix

* rename variables for clarity

* fixes conditional logic for consent allows function (#13)

* [RPO-3262] Update getUid function to check for pubcid and sharedid (#14)

* Update getUid function to check for pubcid and sharedid

* updates adapter version

* [RPO-3405] Add browserLanguage to request meta object

---------

Co-authored-by: antoin <antoin.campbell@voxmedia.com>
Co-authored-by: Antoin <antoinfive@gmail.com>
Co-authored-by: Brett Bloxom <38990705+BrettBlox@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snapwich snapwich snapwich approved these changes

@dbridges12 dbridges12 Awaiting requested review from dbridges12

Assignees

@moonshells moonshells

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moonshells @snapwich