-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow custom cmd option for rubocop #48
Conversation
Pull Request Test Coverage Report for Build 447927375Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
@bbatsov would you be able to review this? |
Gentle bump. @koic perhaps if you are able? |
Also registering interest for this simple but essential feature. |
Yes, works great with spring to generate a binstub for rubocop so you can start executing it even faster. |
I'd also like to just execute rubocop within guard for modified files only. Example cmd:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. However I don't have release authority of this gem.
@yujinakayama @bbatsov Can you review and release this one?
Ops, seems I had unwatched this repo by accident and didn't see the previous messages. Sorry about that! This change looks good indeed, but should also be mentioned in the changelog and the README (otherwise it's unlikely that someone will find it). |
Thanks Team! I've updated the README. |
Hmm, something's wrong with the CI build. |
Looks like that issue is very intermittent from multiple posts to coveralls. References: |
Okay, I'll merge this and I'll cut a new release after we update the CI for Ruby 3. |
Or I can update the CI over this weekend and cut a new release. (coverall's issue may be commented out as a workaround) |
This PR is a workaround for rubocop#48 (comment).
This PR is a workaround for rubocop#48 (comment).
I've released v1.5.0. Thank you! |
Add a custom command option for when you want to use bundled or bin stubbed version of rubocop.