Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support Ruby 2.4 #50

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Drop support Ruby 2.4 #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
ruby: [2.4, 2.5, 2.6, 2.7]
ruby: [2.5, 2.6, 2.7]
steps:
- uses: actions/checkout@v2
- uses: ruby/setup-ruby@v1
Expand Down
3 changes: 3 additions & 0 deletions .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
inherit_from: .rubocop_todo.yml

AllCops:
TargetRubyVersion: 2.5

Layout/FirstArrayElementIndentation:
EnforcedStyle: consistent

Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## Development

* Drop support Ruby 2.4. [#50](https://github.com/rubocop/guard-rubocop/pull/50)

## v1.4.0

* Support RuboCop 1.0
Expand Down
2 changes: 1 addition & 1 deletion guard-rubocop.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Gem::Specification.new do |spec|
spec.homepage = 'https://github.com/rubocop-hq/guard-rubocop'
spec.license = 'MIT'

spec.required_ruby_version = '>= 2.4'
spec.required_ruby_version = '>= 2.5'

spec.files = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
spec.executables = spec.files.grep(/^bin\//) { |f| File.basename(f) }
Expand Down
8 changes: 3 additions & 5 deletions lib/guard/rubocop/runner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,9 @@ def json_file_path
end

def result
@result ||= begin
File.open(json_file_path) do |file|
# Rubinius 2.0.0.rc1 does not support `JSON.load` with 3 args.
JSON.parse(file.read, symbolize_names: true)
end
@result ||= File.open(json_file_path) do |file|
# Rubinius 2.0.0.rc1 does not support `JSON.load` with 3 args.
JSON.parse(file.read, symbolize_names: true)
end
end

Expand Down