Add a type predicate dot? to Token
#231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobuyo
force-pushed
the
add-dot-type-predicate-method-to-token
branch
from
552a45c
to
b8bc457
Compare
|
Sorry for the delay, yes, definitely! Please rebase to resolve conflicts at your convenience, or let me know if you'd prefer me to do it. Thank! |
nobuyo
force-pushed
the
add-dot-type-predicate-method-to-token
branch
from
b8bc457
to
4a87916
Compare
|
Thanks for your response! I've resolved conflicts. |
|
Released, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was working on fixing Cop related to dot position in rubocop/rubocop, I thought it would be nice to have
dot?in the Token.I ended up taking a different approach at the time, but I'm sending a PR because I think it may be used in the future.