Fix #macro? for numblock nodes #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsamokovarov
force-pushed
the
macro-in-numblock
branch
3 times, most recently
from
3ba094c
to
8c309cc
Compare
koic
reviewed
Aug 6, 2022
We can have macros in numblocks. I found this issue while working on broader `numblock` nodes support for cops in rubocop and found out that the`#bare_access_modifier?` method was not giving proper results for modifiers in numblocks. This applies to other methods that depend on the `#macro?` methods.
gsamokovarov
force-pushed
the
macro-in-numblock
branch
from
8c309cc
to
1dbd943
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can have macros in numblocks. I found this issue while working on broader
numblocknodes support for cops in rubocop and found out that the#bare_access_modifier?method was not giving proper results for modifiers in numblocks. This applies to other methods that depend on the#macro?method.