Add node types forwarded_restarg and forwarded_kwrestarg
#245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is added the node types added by whitequark/parser#874
ydah
force-pushed
the
add_forwarded_restarg_forwarded_kwrestarg
branch
from
ed7018e
to
276261c
Compare
koic
reviewed
Nov 30, 2022
| @@ -120,6 +120,10 @@ The following fields are given when relevant to nodes in the source code: | |||
|
|
|||
| |forwarded-args|Forwarding arguments into a method call|None|foo(...)|N/A | |||
|
|
|||
| |forwarded-restarg|Forwarding positional arguments into a method call|None|foo(*)|N/A | |||
There was a problem hiding this comment.
Suggested change
| |forwarded-restarg|Forwarding positional arguments into a method call|None|foo(*)|N/A | |
| |forwarded-restarg|Forwarding rest arguments into a method call|None|foo(*)|N/A |
There was a problem hiding this comment.
Both work; I'm fine with "positional" as it's very clear 👍
|
Thank you @ydah ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is added the node types added by whitequark/parser#874
Now CI seems to be failing as well:
https://github.com/rubocop/rubocop-ast/actions/runs/3581987367/jobs/6025686164#step:9:33