Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodePattern: Allow full expressions as function arguments #63

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

marcandre
Copy link
Contributor

No description provided.

@marcandre marcandre mentioned this pull request Jul 11, 2020
@marcandre marcandre force-pushed the node_pattern_arg branch 2 times, most recently from 719f5d1 to bd3102c Compare July 11, 2020 22:55
@@ -316,6 +316,30 @@ We can use the `#prime?` method directly in the expression:
(int #prime?)
----

== Arguments for predicate and external methods
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

predicates and external methods? I'm confused by this terminology. :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, I'll replace "external methods" with "funcall", which is what is used elsewhere (predicate?, #funcall)

@bbatsov
Copy link
Contributor

bbatsov commented Jul 12, 2020

Looks cool to me. I only find the terminology confusing - e.g. what's special about predicate methods.

@marcandre marcandre merged commit f93da20 into rubocop:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants