Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Performance/RedundantStringChars cop error in case of implicit receiver #478

Conversation

viralpraxis
Copy link
Contributor

@viralpraxis viralpraxis commented Dec 11, 2024

echo 'chars.size' | be rubocop --only Performance/RedundantStringChars --stdin bug.rb -d

Inspecting 1 file
Scanning bug.rb
An error occurred while Performance/RedundantStringChars cop was inspecting bug.rb:1:0.
undefined method `begin_pos' for nil
lib/rubocop/cop/performance/redundant_string_chars.rb:76:in `correction_range'
lib/rubocop/cop/performance/redundant_string_chars.rb:62:in `block in on_send'

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…receiver

```console
echo 'chars.size' | be rubocop  --only Performance/RedundantStringChars --stdin bug.rb -d

Inspecting 1 file
Scanning /bug.rb
An error occurred while Performance/RedundantStringChars cop was inspecting /bug.rb:1:0.
undefined method `begin_pos' for nil
/lib/rubocop/cop/performance/redundant_string_chars.rb:76:in `correction_range'
/lib/rubocop/cop/performance/redundant_string_chars.rb:62:in `block in on_send'
```
@koic koic merged commit 9248192 into rubocop:master Dec 11, 2024
14 checks passed
@koic
Copy link
Member

koic commented Dec 11, 2024

Thanks!

@viralpraxis viralpraxis deleted the fix-performance-redundant-string-chars-cop-error-in-case-of-implicit-receiver branch December 11, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants