Skip to content

Commit

Permalink
Cut 2.17.4
Browse files Browse the repository at this point in the history
  • Loading branch information
koic committed Dec 25, 2022
1 parent 3032b74 commit 836ff28
Show file tree
Hide file tree
Showing 5 changed files with 44 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

## master (unreleased)

## 2.17.4 (2022-12-25)

### Bug fixes

* [#870](https://github.com/rubocop/rubocop-rails/issues/870): Fix an error for `Rails/RootPathnameMethods` when using `Rails.env` argument within `Dir.glob`. ([@koic][])
Expand Down
2 changes: 1 addition & 1 deletion docs/antora.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ name: rubocop-rails
title: RuboCop Rails
# We always provide version without patch here (e.g. 1.1),
# as patch versions should not appear in the docs.
version: ~
version: '2.17'
nav:
- modules/ROOT/nav.adoc
21 changes: 21 additions & 0 deletions docs/modules/ROOT/pages/cops_rails.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -846,6 +846,11 @@ class Post < ApplicationRecord
end
----

=== References

* https://guides.rubyonrails.org/5_0_release_notes.html
* https://github.com/rails/rails/pull/18937

== Rails/Blank

|===
Expand Down Expand Up @@ -1039,6 +1044,11 @@ end
| Array
|===

=== References

* https://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/SchemaStatements.html#method-i-change_table
* https://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/Table.html

== Rails/CompactBlank

|===
Expand Down Expand Up @@ -2844,6 +2854,7 @@ end

=== References

* https://api.rubyonrails.org/classes/AbstractController/Callbacks/ClassMethods.html#method-i-_normalize_callback_options
* https://api.rubyonrails.org/classes/AbstractController/Callbacks/ClassMethods.html#method-i-_normalize_callback_options

== Rails/IndexBy
Expand Down Expand Up @@ -3126,6 +3137,11 @@ end
| Array
|===

=== References

* https://guides.rubyonrails.org/association_basics.html#bi-directional-associations
* https://api.rubyonrails.org/classes/ActiveRecord/Associations/ClassMethods.html#module-ActiveRecord::Associations::ClassMethods-label-Setting+Inverses

== Rails/LexicallyScopedActionFilter

|===
Expand Down Expand Up @@ -4921,6 +4937,7 @@ end

* https://rails.rubystyle.guide#reversible-migration
* https://api.rubyonrails.org/classes/ActiveRecord/Migration/CommandRecorder.html
* https://api.rubyonrails.org/classes/ActiveRecord/Migration/CommandRecorder.html

== Rails/ReversibleMigrationMethodDefinition

Expand Down Expand Up @@ -6023,6 +6040,10 @@ ApplicationRecord.transaction do
end
----

=== References

* https://github.com/rails/rails/commit/15aa4200e083

== Rails/UniqBeforePluck

|===
Expand Down
2 changes: 1 addition & 1 deletion lib/rubocop/rails/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module RuboCop
module Rails
# This module holds the RuboCop Rails version information.
module Version
STRING = '2.17.3'
STRING = '2.17.4'

def self.document_version
STRING.match('\d+\.\d+').to_s
Expand Down
19 changes: 19 additions & 0 deletions relnotes/v2.17.4.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
### Bug fixes

* [#870](https://github.com/rubocop/rubocop-rails/issues/870): Fix an error for `Rails/RootPathnameMethods` when using `Rails.env` argument within `Dir.glob`. ([@koic][])
* [#881](https://github.com/rubocop/rubocop-rails/pull/881): Fix a false positive for `Rails/ActionControllerFlashBeforeRender` when using `flash` in multiline `rescue` branch before `redirect_to`. ([@gurix][])
* [#871](https://github.com/rubocop/rubocop-rails/pull/871): Fix a false positive for `Rails/WhereMissing` when `left_joins(:foo)` and `where(foos: {id: nil})` separated by `or`, `and`. ([@ydah][])
* [#875](https://github.com/rubocop/rubocop-rails/pull/875): Make `Rails/RootPathnameMethods` aware of enforced style of `Style/StringLiterals`. ([@koic][])
* [#882](https://github.com/rubocop/rubocop-rails/pull/882): Fix false positive for `Rails/UniqueValidationWithoutIndex` with :conditions option. ([@etiennebarrie][])
* [#821](https://github.com/rubocop/rubocop-rails/issues/821): Enhance `Rails/TimeZone` to accept methods with the `:in` timezone option. ([@fatkodima][])

### Changes

* [#880](https://github.com/rubocop/rubocop-rails/pull/880): Add Rails/I18nLocaleTexts match for redirect_back. ([@bensheldon][])

[@koic]: https://github.com/koic
[@gurix]: https://github.com/gurix
[@ydah]: https://github.com/ydah
[@etiennebarrie]: https://github.com/etiennebarrie
[@fatkodima]: https://github.com/fatkodima
[@bensheldon]: https://github.com/bensheldon

0 comments on commit 836ff28

Please sign in to comment.