-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An error occurred while Rails/ActionOrder cop was inspecting files #841
Labels
bug
Something isn't working
Comments
koic
added a commit
to koic/rubocop-rails
that referenced
this issue
Nov 8, 2022
Fixes rubocop#841. This PR fixes an error for `Rails/ActionOrder` when using unconventional order of multiple actions. With this change, autocorrection blank line positions are not as expected, so they are left to autocorrection of `Layout/EmptyLineBetweenDefs` and `Layout/EmptyLinesAroundClassBody` cops. This PR aims to fix the error, that it may be a cleaner autocorrection later.
9 tasks
koic
added a commit
to koic/rubocop-rails
that referenced
this issue
Nov 8, 2022
Fixes rubocop#841. This PR fixes an error for `Rails/ActionOrder` when using unconventional order of multiple actions. With this change, autocorrection blank line positions are not as expected, so they are left to autocorrection of `Layout/EmptyLineBetweenDefs` and `Layout/EmptyLinesAroundClassBody` cops. This PR aims to fix the error, that it may be a cleaner autocorrection later.
koic
added a commit
to koic/rubocop-rails
that referenced
this issue
Nov 8, 2022
Fixes rubocop#841. This PR fixes an error for `Rails/ActionOrder` when using unconventional order of multiple actions. With this change, autocorrection blank line positions are not as expected, so they are left to autocorrection of `Layout/EmptyLineBetweenDefs` and `Layout/EmptyLinesAroundClassBody` cops. This PR aims to fix the error, that it may be a better autocorrection later.
koic
added a commit
to koic/rubocop-rails
that referenced
this issue
Nov 10, 2022
Fixes rubocop#841. This PR fixes an error for `Rails/ActionOrder` when using unconventional order of multiple actions. With this change, autocorrection blank line positions are not as expected, so they are left to autocorrection of `Layout/EmptyLineBetweenDefs` and `Layout/EmptyLinesAroundClassBody` cops. This PR aims to fix the error, that it may be a better autocorrection later.
koic
added a commit
that referenced
this issue
Nov 11, 2022
[Fix #841] Fix an error for `Rails/ActionOrder`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I might have found a bug in version
2.17.1
in theRails/ActionOrder
. See the stacktrace below.Expected behavior
I expect RuboCop to not produce an error.
Actual behavior
Stacktrace:
Steps to reproduce the problem
This is the file which is causing the issue: https://github.com/openSUSE/open-build-service/blob/e479c616af873f4ae9f3ef538e5a38d2133913f9/src/api/app/controllers/webui/project_controller.rb
RuboCop version
The text was updated successfully, but these errors were encountered: