[Regression] Rails/FreezeTime gives invalid suggestion when travel_to is passed a Ruby expression

[christos]

This looks like a partial regression of #769

It happens when the arguments passed to travel_to is a Ruby expression more complex than simply a Time/Date instantiation.

• Time.new(2019, 4, 3, 12, 30).in_time_zone triggers the bug
• Time.new(2019, 4, 3, 12, 30) doesn't trigger the bug
• Time.new.in_time_zone(2019, 4, 3, 12, 30) doesn't trigger the bug is not valid syntax

Expected behaviour

RuboCop Rails should not have suggested to replace travel_to a_ruby_expression with freeze_time

Actual behavior

RuboCop Rails suggested to autocorrect a travel_to with a ruby expression with freeze_time

Steps to reproduce the problem

In a Rails 7 project, add the following code to a file spec/rails_time_freeze_spec.rb

# frozen_string_literal: true

travel_to Time.new(2019, 4, 3, 12, 30).in_time_zone do
  expect("travel_to").to_not eq("freeze_time")
end

Run bin/rubocop spec/rails_time_freeze_spec.rb

Output is

Inspecting 1 file
C

Offenses:

spec/rails_time_freeze_spec.rb:3:1: C: [Correctable] Rails/FreezeTime: Use freeze_time instead of travel_to.
travel_to Time.new(2019, 4, 3, 12, 30).in_time_zone do
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected, 1 offense autocorrectable

RuboCop version

$ [bundle exec] rubocop -V
1.37.1 (using Parser 3.1.2.1, rubocop-ast 1.23.0, running on ruby 3.1.2) [arm64-darwin21]
  - rubocop-performance 1.14.3
  - rubocop-rails 2.17.2
  - rubocop-rspec 2.14.2