Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #1199] Make Rails/WhereEquals aware of where.not(...) #1323

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

Earlopain
Copy link
Contributor

@Earlopain Earlopain commented Aug 10, 2024

Fix #1199

This copies a bit of logic from WhereRange but they need slighly different handling and it doesn't seem worth to extract yet.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

This copies a bit of logic from `WhereRange` but they need slighly
different handling and it doesn't seem worth to extract yet.
@koic koic merged commit 5617426 into rubocop:master Aug 15, 2024
14 checks passed
@koic
Copy link
Member

koic commented Aug 15, 2024

Thanks!

@Earlopain Earlopain deleted the where-equal-not branch August 17, 2024 13:07
@Earlopain
Copy link
Contributor Author

@koic, the changelog type should have been change, right? I feel like that would be more appropriate. If you feel the same, just fix in main. Thanks!

koic added a commit that referenced this pull request Aug 17, 2024
koic added a commit to koic/rubocop-rails that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Rails/WhereEquals aware of where.not
2 participants