[Fix #221] Make Rails/UniqueValidationWithoutIndex aware of add_index
#222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
make_unique_validation_without_index_aware_of_add_index
branch
2 times, most recently
from
41c6eaa to
a77506a
Compare
…`add_index` Fixes rubocop#221. This PR makes `Rails/UniqueValidationWithoutIndex` aware of `add_index` in db/schema.rb. Rails 4.0 and Rails 4.1 support will drop shortly, but Rails 4.2 may be a bit ahead. There may be changes to these support after the bug fix release of RoboCop Rails 2.5 series.
koic
force-pushed
the
make_unique_validation_without_index_aware_of_add_index
branch
from
a77506a to
3fa9c7c
Compare
koic
deleted the
make_unique_validation_without_index_aware_of_add_index
branch
koic
added a commit
to koic/rubocop-rails
that referenced
this pull request
Apr 21, 2020
Follow up to rubocop#222. This PR drops support for Rails 4.1 or lower. RuboCop Rails 2.6 will drop support for Rails 4.1 or lower. Maybe RuboCop Rails 3.0 will drop Rails 4 series support in future. RuboCop Rails is currently negative support for Rails 4 series, and new features for Rails 4 will basically not be accepted.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #221.
This PR makes
Rails/UniqueValidationWithoutIndexaware ofadd_indexin db/schema.rb.Rails 4.0 and Rails 4.1 support will drop shortly, but Rails 4.2 may be a bit ahead. There may be changes to these support after the bug fix release of RoboCop Rails 2.5 series.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.