-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autocorrection for Rails/ReflectionClassName
#299
Add autocorrection for Rails/ReflectionClassName
#299
Conversation
|
d17dbb7
to
dfc20d7
Compare
@tejasbubane ping. |
dfc20d7
to
fc90afb
Compare
@koic Sorry for the delay on this one, I've made the changes to autocorrect only for constants or |
fc90afb
to
504f14d
Compare
@tejasbubane Can you rebase with the latest master branch? |
504f14d
to
52578e2
Compare
@koic Rebased. |
Thanks! |
Is there an advantage to using this rule or is this just a stylistic choice? The advantage I can see to using reflection is that if a class name changes and your relation relies on it, it will be obvious very quickly as your app will fail to start if you have failed to update references to the underlying class. |
It will fail both ways, won’t it? |
Ah I see. If there's a circular dependency. Thanks. |
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).and description in grammatically correct, complete sentences.
bundle exec rake default
. It executes all tests and RuboCop for itself, and generates the documentation.