-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Rails/ActiveSupportOnLoad cop. #749
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdewater
force-pushed
the
active-support-on-load
branch
from
September 5, 2022 21:10
e3c173f
to
b62814d
Compare
bdewater
force-pushed
the
active-support-on-load
branch
from
September 5, 2022 22:34
b62814d
to
43915bc
Compare
andyw8
reviewed
Sep 5, 2022
bdewater
force-pushed
the
active-support-on-load
branch
2 times, most recently
from
September 6, 2022 15:15
a4f4562
to
7f213f8
Compare
Not sure what's going on with the test failures - they don't seem related to the changes and locally on the master branch seeing the same errors. |
bdewater
force-pushed
the
active-support-on-load
branch
from
September 6, 2022 18:40
7f213f8
to
d993814
Compare
koic
reviewed
Sep 7, 2022
koic
reviewed
Sep 7, 2022
koic
reviewed
Sep 7, 2022
koic
reviewed
Sep 7, 2022
koic
reviewed
Sep 7, 2022
koic
reviewed
Sep 7, 2022
koic
reviewed
Sep 7, 2022
koic
reviewed
Sep 7, 2022
koic
reviewed
Sep 7, 2022
koic
reviewed
Sep 7, 2022
bdewater
force-pushed
the
active-support-on-load
branch
2 times, most recently
from
September 7, 2022 15:11
513420d
to
d598a72
Compare
Thank you for your suggestions @koic 🙇♂️ it led me to a Rails page that showed many more load hooks, I added these as well. |
koic
reviewed
Sep 8, 2022
bdewater
force-pushed
the
active-support-on-load
branch
from
September 8, 2022 14:59
d598a72
to
92762c4
Compare
koic
reviewed
Sep 8, 2022
bdewater
force-pushed
the
active-support-on-load
branch
from
September 8, 2022 21:59
92762c4
to
e340acf
Compare
koic
reviewed
Sep 9, 2022
bdewater
force-pushed
the
active-support-on-load
branch
from
September 9, 2022 00:52
e340acf
to
27e5020
Compare
This cop is extracted from Shopify's internal Rubocop repository. Many thanks to the original authors for their work. Co-authored-by: Julian Nadeau <julian@jnadeau.ca> Co-authored-by: Rafael Mendonça França <rafael.franca@shopify.com> Co-authored-by: Francois Chagnon <francois.chagnon@shopify.com> Co-authored-by: Jean Boussier <jean.boussier@gmail.com>
bdewater
force-pushed
the
active-support-on-load
branch
from
September 9, 2022 01:09
27e5020
to
32b9839
Compare
@bdewater Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rubocop/rails-style-guide#323
This cop is extracted from Shopify's internal Rubocop repository. Many thanks to the original authors for their work.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.