Fix errors that occur when unrelated tag
is investigated by Rails/ContentTag
#813
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a strange error when running rubocop-rails on our Rails app that uses FactoryBot.
The file that caused the problem was, in simplified form, the following code:
and the error output was like this:
This Pull Request has been created to fix this problem.
We could add
{spec,test}/factories/**/*.rb
toExclude
section of this cop, but that would not prevent the problem from reoccuring in other places. Since extensive investigation is performed on the generic method nametag
, I think it should be checked more rigorously in this way.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.