Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an incorrect autocorrect for Rails/Presence when a right-hand side of the relational operator #816

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

ydah
Copy link
Member

@ydah ydah commented Oct 19, 2022

This PR fixes an incorrect autocorrect when there is right-hand side of the relational operator as follows:

a < if b.present?
  b
else
  c
end

Expect autocorrect

a < (b.presence || c)

Actual autocorrect

a < b.presence || c

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • [-] Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • [-] If this is a new cop, consider making a corresponding update to the Rails Style Guide.

…ide of the relational operator

This PR fixes an incorrect autocorrect when there is right-hand side of the relational operator as follows:
```ruby
a < if b.present?
  b
else
  c
end
```

Expect autocorrect
```ruby
a < (b.presence || c)
```

Actual autocorrect
```ruby
a < b.presence || c
```
@ydah
Copy link
Member Author

ydah commented Oct 20, 2022

I updated this PR. Thank you so much.

@koic koic merged commit 25d9dfb into rubocop:master Oct 20, 2022
@koic
Copy link
Member

koic commented Oct 20, 2022

Thanks!

@ydah ydah deleted the fix/presence branch October 21, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants