Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rails/RootPathnameMethods autocorrection for Pathname calls without parens #855

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

gsamokovarov
Copy link
Contributor

# I run into case where...
file = File.open Rails.root.join 'spec', 'fixtures', 'pdfs', 'read_only.pdf'

# Got autocrrected to... 👇
file = Rails.root.join 'spec', 'fixtures', 'pdfs', 'read_only.pdf'.open

This autocorrection is invalid Ruby code. We can avoid it if we parenthesize Pathname methods before chaining like so:

file = Rails.root.join('spec', 'fixtures', 'pdfs', 'read_only.pdf').open

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

…ut parens

```ruby
# I run into case where...
file = File.open Rails.root.join 'spec', 'fixtures', 'pdfs', 'read_only.pdf'

# Got autocrrected to... 👇
file = Rails.root.join 'spec', 'fixtures', 'pdfs', 'read_only.pdf'.open
```

This autocorrection is invalid Ruby code. We can avoid it if we
parenthesize `Pathname` methods before chaining like so:

```
file = Rails.root.join('spec', 'fixtures', 'pdfs', 'read_only.pdf').open
```
@gsamokovarov gsamokovarov force-pushed the pathname-parens-autocorrect branch from aaf4aba to 3df1615 Compare November 3, 2022 10:20
@koic koic merged commit 2a96132 into rubocop:master Nov 3, 2022
@koic
Copy link
Member

koic commented Nov 3, 2022

Thank you,Genadi!

@gsamokovarov gsamokovarov deleted the pathname-parens-autocorrect branch November 14, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants