Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Rails/RootPathnameMethods aware of enforced style of Style/StringLiterals #875

Conversation

koic
Copy link
Member

@koic koic commented Nov 25, 2022

Follow up #872 (comment).

This PR makes Rails/RootPathnameMethods aware of enforced style of Style/StringLiterals.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

…ringLiterals`

Follow up rubocop#872 (comment).

This PR makes `Rails/RootPathnameMethods` aware of enforced style of `Style/StringLiterals`.
@koic koic force-pushed the make_rails_root_pathname_methods_aware_of_style_string_literals branch from 57544c7 to e8ffc7e Compare November 25, 2022 17:31
@koic koic merged commit 770e6bd into rubocop:master Nov 28, 2022
@koic koic deleted the make_rails_root_pathname_methods_aware_of_style_string_literals branch November 28, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant