Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise severity of some cops to warning #896

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

koic
Copy link
Member

@koic koic commented Dec 24, 2022

The cops below belong to linting, not style preference, so make set the severity to warning.

The following emulates warnings for deprecated APIs:

  • Rails/DeprecatedActiveModelErrorsMethods
  • Rails/TopLevelHashWithIndifferentAccess
  • Rails/WhereNotWithMultipleConditions

The following suggests incorrect usage of APIs:

  • Rails/ActiveRecordOverride
  • Rails/DuplicateAssociation
  • Rails/DuplicateScope

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
  • If this is a new cop, consider making a corresponding update to the Rails Style Guide.

The cops below belong to linting, not style preference,
so make set the severity to warning.

The following emulates warnings for deprecated APIs:

- Rails/DeprecatedActiveModelErrorsMethods
- Rails/TopLevelHashWithIndifferentAccess
- Rails/WhereNotWithMultipleConditions

The following suggests incorrect usage of APIs:

- Rails/ActiveRecordOverride
- Rails/DuplicateAssociation
- Rails/DuplicateScope
@koic koic merged commit 5425d8a into rubocop:master Jan 11, 2023
@koic koic deleted the raise_severity_of_some_cops_to_warning branch January 11, 2023 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant