-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error in Rails/Presence
when ternary operators are used in multiple lines
#931
Merged
koic
merged 1 commit into
rubocop:master
from
r7kamura:feature/presense-multiline-ternary
Feb 10, 2023
Merged
Fix error in Rails/Presence
when ternary operators are used in multiple lines
#931
koic
merged 1 commit into
rubocop:master
from
r7kamura:feature/presense-multiline-ternary
Feb 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r7kamura
force-pushed
the
feature/presense-multiline-ternary
branch
from
February 8, 2023 04:28
8f7a032
to
3cce241
Compare
The actual error I encountered was as follows:
|
r7kamura
force-pushed
the
feature/presense-multiline-ternary
branch
from
February 8, 2023 04:34
3cce241
to
1bb961d
Compare
koic
reviewed
Feb 10, 2023
This looks good. Can you squash commits into one? |
OK, I'll squash them 👌 |
r7kamura
force-pushed
the
feature/presense-multiline-ternary
branch
from
February 10, 2023 19:08
2ec4f7c
to
fc38085
Compare
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I run rubocop-rails against the following code, I get an error from
Rails/Presence
cop.After investigation, I have identified the problem and would like to fix it.
Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.