Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RSpec/NoExpectationExample #1321

Merged
merged 8 commits into from
Jul 27, 2022
Merged

Add RSpec/NoExpectationExample #1321

merged 8 commits into from
Jul 27, 2022
+252 −1

Commits on Jul 12, 2022

  1. Add RSpec/NoExpectationExample 

    In response to the review comments, I added the following changes later:

- Prefer x_type? to is_a?
- Use RSpec.Language.Examples
- Add are_expected to expectation method names
- Prefer on_block to on_send
- Add more methods to RSpec.Language.Expectations
- Use RSpec.Language.Expectations
- Replace with clearer custom method names
- Add some missing \@return comments
    @r7kamura
    r7kamura committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    48ea016 View commit details
    Browse the repository at this point in the history

  2. Use def_node_search to implement #including_any_expectation?

    @r7kamura
    r7kamura committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    17f66c2 View commit details
    Browse the repository at this point in the history

  3. Improve wording: "includes" -> "contains"

    @r7kamura
    r7kamura committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    03de7b1 View commit details
    Browse the repository at this point in the history

  4. Remove autocorrect support from RSpec/NoExpectationExample

    @r7kamura
    r7kamura committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    c9ac59c View commit details
    Browse the repository at this point in the history

  5. Replace example_method_call? with existing example?

    @r7kamura
    r7kamura committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    0370b02 View commit details
    Browse the repository at this point in the history

  6. Add changelog entry about Expectations change

    @r7kamura
    r7kamura committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    7a3a0a6 View commit details
    Browse the repository at this point in the history

  7. Improve test example group messages

    @r7kamura
    r7kamura committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    f9c02de View commit details
    Browse the repository at this point in the history

  8. Skip checking of pending or skipped examples

    @r7kamura
    r7kamura committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    ed7f7c0 View commit details
    Browse the repository at this point in the history