-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI task testing with the oldest RuboCop version allowed by gemspec #1882
Conversation
24b3393
to
340dce2
Compare
340dce2
to
1e17db7
Compare
Nice! can the failure be caused by some default TargetRubyVersion setting for that older RuboCop version? |
It turns out that the issue was fixed by adding |
1e17db7
to
e9a9d2e
Compare
The problem is fixed; PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic!
Frankly I was afraid that something’s broken and it’s just a coincidence that people update rubocop and rubocop-rspec simultaneously 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Fixes: #1879 (comment)
Before submitting the PR make sure the following are checked:
master
(if not - rebase it).CHANGELOG.md
if the new code introduces user-observable changes.bundle exec rake
) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).