Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.30.0 #1897

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Release v2.30.0 #1897

merged 1 commit into from
Jun 3, 2024

Conversation

bquorning
Copy link
Collaborator

The only change visible to our users is the addition of the RSpec/ExpectInLet cop.


Before submitting the PR make sure the following are checked:

  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Updated documentation.
  • Added an entry to the CHANGELOG.md if the new code introduces user-observable changes.
  • The build (bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).

@bquorning bquorning marked this pull request as ready for review June 3, 2024 06:00
@bquorning bquorning requested a review from a team as a code owner June 3, 2024 06:00
@bquorning bquorning requested review from pirj and ydah June 3, 2024 06:01
@ydah
Copy link
Member

ydah commented Jun 3, 2024

If we are not in a hurry, I would like to include the following PR.
#1883

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bquorning
Copy link
Collaborator Author

I would like to include the following PR. #1883

I don’t see #1883 as being close to done (no activity for a week), so I think we can just do another release later when there is a PR and it’s merged.

Copy link
Member

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ydah
Copy link
Member

ydah commented Jun 3, 2024

I don’t see #1883 as being close to done (no activity for a week), so I think we can just do another release later when there is a PR and it’s merged.

I thought my personal busyness had calmed down and I could work on it today, but certainly not a strong opinion as we can just release it again. So I have no problem with you proceeding with the release 👍🏻

@bquorning bquorning merged commit 510b019 into 2-x-stable Jun 3, 2024
24 checks passed
@bquorning bquorning deleted the release-2-30-0 branch June 3, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants