-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix
StyleGuideBaseURL
not functioning with nested departments
Currently you can set the StyleGuideBaseURL config for cops that ship within RuboCop or other RuboCop plugins that use a DEPT/COP format. If the project has nested departments this doesn't work as the message annotator does not properly split the cop name to determine the department to lookup. With this change just the cop name is split from the full DEPT/COP string allowing the StyleGuideBaseURL to function with nested departments. We have nested departments in Cookstyle like `Chef/Deprecations/Foo` and we'd like to be able to enable this config by default so we can point our users at our documentation. Signed-off-by: Tim Smith <tsmith@chef.io>
- Loading branch information
Showing
3 changed files
with
27 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
* [#9452](https://github.com/rubocop-hq/rubocop/pull/9452): Fix `StyleGuideBaseURL` not functioning with nested departments. ([@tas50][]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters