Redundant block call parentheses #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for fixing my code. |
rrosenblum
force-pushed
the
redundant_block_call_parentheses
branch
from
6d0393f to
04ae9c7
Compare
|
Welcome, I don't expect this to be a problem for too many people. Regardless of impact, it was worth fixing. I came across one or two more bugs with the new release. I will try to get PRs in for them soon. |
rrosenblum
force-pushed
the
redundant_block_call_parentheses
branch
from
04ae9c7 to
0a30b93
Compare
|
The build is failing. |
rrosenblum
force-pushed
the
redundant_block_call_parentheses
branch
from
0a30b93 to
01c78b6
Compare
bbatsov
added a commit
that referenced
this pull request
Jan 21, 2016
…eses Redundant block call parentheses
jonas054
added a commit
to jonas054/rubocop
that referenced
this pull request
Jan 30, 2016
Operands in expressions that are the right-hand-side in an assignment where there's a line break after = should be aligned with each other, regardless of configured style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across an edge case that caused auto-correct to break the code. Take a look at the second test case for the example code.