Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor URI Parsing Spec #68

Merged
merged 8 commits into from
Dec 6, 2017
Merged

Refactor URI Parsing Spec #68

merged 8 commits into from
Dec 6, 2017

Conversation

Tensho
Copy link
Contributor

@Tensho Tensho commented Dec 6, 2017 •
edited
Loading

This is a follow up to #67.

Improvements

  • Allow focus on specs (required upgrade rspec from 3.4.0 to 3.5.0)
  • Add byebug gem to development and test bundler groups
  • Declare simplecov gem explicitly in bundle
  • Require gems in bundle automatically
  • Require spec_helper within .rspec file
  • Disable rspec money patching
  • Remove redundant ruby file encoding declarations

@michaelklishin
Copy link
Member

Thank you!

@michaelklishin michaelklishin merged commit 09aa3b6 into ruby-amqp:master Dec 6, 2017
@Tensho Tensho deleted the uri-parsing-refactoring branch December 7, 2017 07:43
@Tensho
Copy link
Contributor Author

Tensho commented Dec 7, 2017

@michaelklishin, Could you bump a new version and release it to rubygems, so I could refer to it in bunny and amqp gems?

@Tensho
Copy link
Contributor Author

Tensho commented Dec 7, 2017

@michaelklishin, Could you bump a new version and release it to rubygems, so I could refer to it in bunny and amqp gems?

I've just noticed, that bunny depends on the amq-protocol master branch. Sorry, there is no worries.

This was referenced Dec 20, 2017
Closed
Merged
Merged
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Mar 14, 2018
net/ruby-amq-protocol: update to 2.3.0
9f3220b 
## Changes between 2.2.0 and 2.3.0 (Jan 8th, 2018)

### Support for Additional URI Query Parameters

GitHub issue: [#67](ruby-amqp/amq-protocol#67), [#68](ruby-amqp/amq-protocol#68), [#69](ruby-amqp/amq-protocol#69).

Contributed by Andrew Babichev.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tensho @michaelklishin