URI improvements #159
Merged
URI improvements #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 We spent quite a while trying to puzzle out why Hutch was failing to parse certain |
|
Thank you, some (mock-based) tests need updating, I'll take care of that. |
|
I'm running into obscure github issues at the moment when trying to push, will contact support and push in the next few days. |
michaellennox
pushed a commit
to michaellennox/hutch
that referenced
this pull request
Jan 16, 2018
In ruby-amqp#159 functionality was added to hutch that meant that it would respect that when using `amqps://` as the URI scheme it would use TLS and also that when not specifying a port in the URI scheme it would default to the standard protocol ports (5671 for TLS connections, 5672 for non TLS connections). This functionality appears to have been lost since and is restored by this commit it also adds a new test case to prevent another regression.
michaellennox
pushed a commit
to michaellennox/hutch
that referenced
this pull request
Jan 16, 2018
In ruby-amqp#159 functionality was added to hutch that meant that it would respect that when using `amqps://` as the URI scheme it would use TLS and also that when not specifying a port in the URI scheme it would default to the standard protocol ports (5671 for TLS connections, 5672 for non TLS connections). This functionality appears to have been lost since and is restored by this commit it also adds a new test case to prevent another regression.
michaellennox
pushed a commit
to michaellennox/hutch
that referenced
this pull request
Jan 16, 2018
In ruby-amqp#159 functionality was added to hutch that meant that it would respect that when using `amqps://` as the URI scheme it would use TLS and also that when not specifying a port in the URI scheme it would default to the standard protocol ports (5671 for TLS connections, 5672 for non TLS connections). This functionality appears to have been lost since and is restored by this commit it also adds a new test case to prevent another regression.
michaellennox
pushed a commit
to michaellennox/hutch
that referenced
this pull request
Jan 16, 2018
In ruby-amqp#159 functionality was added to hutch that meant that it would respect that when using `amqps://` as the URI scheme it would use TLS and also that when not specifying a port in the URI scheme it would default to the standard protocol ports (5671 for TLS connections, 5672 for non TLS connections). This functionality appears to have been lost since and is restored by this commit it also adds a new test case to prevent another regression.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect "amqps://" in the URI and use the default protocol ports (5672 and 5671) if no port is supplied in the URI