Perform a VM-wide thread stack trace dump on USR2 #263
Conversation
|
|
||
| sig = sig_read.gets.strip.downcase | ||
| if USER_SIGNALS.include?(sig.upcase) | ||
| logger.info "FUN TIME! #{sig}" |
There was a problem hiding this comment.
I appreciate the humour but perhaps we should make this log message a bit more descriptive :)
There was a problem hiding this comment.
Ah, I should have written "This is a handler for signal SIGUSR1, the behavior of which we will define as a community".
The current implementation is only a skeleton logging "proof" that it works.
|
Some common signals are If you don't have any specific ideas about what Hutch would do when sent a |
michaelklishin
changed the title
|
It might be useful to allow pausing/resuming of the consumers. I see that Bunny could support pausing the work pool, but I didn't see anything in March Hare after a 2 minute glance. |
|
The only way to pause a consumer is to stop deliveries to it by tweaking QoS prefetch. Otherwise you will run out of memory quickly. This sounds like a dangerous, hard to get right idea to me. |
|
Ah okay sorry, I was looking at Bunny's edit Looking closer I now see that things would still be pushed on to the queue, they just wouldn't be processed. |
- to have a user-facing feature signal, we pick one that can be used on JVM
olleolleolle
force-pushed
the
feature/add-more-signals
branch
from
dbc1efd
to
4611615
Compare
olleolleolle
changed the title
|
I rebased. |
|
So |
| end | ||
|
|
||
| private | ||
|
|
||
| def handle_usr2 | ||
| Thread.list.each do |thread| |
There was a problem hiding this comment.
I suggest that we log a header such as "requested a VM-wide thread stack trace dump…"
| end | ||
|
|
||
| private | ||
|
|
||
| def handle_usr2 | ||
| Thread.list.each do |thread| | ||
| logger.warn "Thread TID-#{thread.object_id.to_s(36)} #{thread['label']}" |
There was a problem hiding this comment.
It should be info!
michaelklishin
changed the title
This is a PR inspired by another project which had a neat section of signals to send to the worker, to have to do things, like "shed current work item, never to requeue it" or "print a debug backtrace".
Inspiration
Questions
Proposed changes