Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gemfile with ruby version marker, instead of specific gemfiles/ files #264

Conversation

olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Nov 19, 2016

This PR changes the Gemfile for the project, to include the Bundler feature ruby RUBY_VERSION, so that Bundler can locate the right gems for the current Ruby version.

Current status: experimental This passes all Travis tests, and does the right thing.

  • hutch.gemspec: Avoid concatenating a String by using line-continuation operator instead.

  - the goal is to allow Bundler to locate the right dependencies for
    things, so that "manual resolution" in special gemfiles/ are not
    necessary.
@olleolleolle olleolleolle changed the title Experiment: Gemfile with ruby version marker Gemfile with ruby version marker Nov 19, 2016
@olleolleolle olleolleolle changed the title Gemfile with ruby version marker Gemfile with ruby version marker, instead of specific gemfiles/ files Nov 19, 2016
@michaelklishin michaelklishin self-assigned this Nov 19, 2016
@michaelklishin michaelklishin merged commit 5e92111 into ruby-amqp:master Nov 19, 2016
@michaelklishin
Copy link
Member

Thank you!

@olleolleolle olleolleolle deleted the fix/bundle-with-ruby-version-marker branch November 19, 2016 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants