Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespace to documentation + Enforce MultiJson usage #356

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

BuonOmo
Copy link
Contributor

@BuonOmo BuonOmo commented Aug 6, 2020

Hi,

I've made a PR for two distinct reasons (hence the two commits!)

Add namespace to the readme 08c8eaf
It seems like a pretty valid config, let's expose it!

enforce MultiJson usage 6cfb105
This allows users to always have their chosen implementation used. And gives a more consistent behavior.

Thanks for the great tool 🚀

@BuonOmo BuonOmo marked this pull request as ready for review August 6, 2020 08:08
@BuonOmo BuonOmo changed the title Add namespace to documentation + Enforce `` Add namespace to documentation + Enforce MultiJson usage Aug 6, 2020
@michaelklishin michaelklishin merged commit b4a6d4b into ruby-amqp:master Aug 6, 2020
@michaelklishin
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants